Robert Nagy

Results 379 comments of Robert Nagy

I'll chime in a link to related PR in Node https://github.com/nodejs/node/pull/29656.

Actually, I think it's not that bad. If we assume the following: if next is thruthy, act like a middleware. if next is falsy, act like a server. Only the...

@RichAyotte it was built with http2 support, simplicity, and performance in mind. The API is much smaller and simpler than `node-http-proxy`. So if there might be some feature that `http-proxy-middleware`...

We keep coming back to `obj.readableNodeStream()` etc... do we want to standardize this interface in some way that could provide best performance regardless which way it's consumed? I tried something...

So there are 2 parts of this, i.e. we usually have two glue steps every time we consume data, e.g. `undici native -> node streams (1) -> web streams (2)...

I'm sorry. I posted that comment in the wrong place. It was meant for https://github.com/nodejs/node/pull/39483. Though I guess it is slightly relevant here as well.

That will cause soo much confusion. I believe there are several methods/props that Buffer override and which act differently than Uint8Array.

In particular `.slice` work differently. Not sure if there are others.

I'm fine with using Uint8Array for Web apis which define the type. But for node api's I think we should stick with Buffer.