Robert Nagy

Results 722 comments of Robert Nagy

I'm happy with the `Duplex` approach. Give it a day or two for others to also voice their opinions before you spend more time on this. Otherwise, you might risk...

Can you check if this fixes it? https://github.com/nodejs/node/pull/54526

@mcollina @Uzlopak seems related to fetch and finalization.

@targos can you fix commit msg (PR-URL)?

> @ronag I don't see a problem in the commit message. @targos > Commit message must match a given regex pattern: PR-URL: https://github\.com/(nodejs|nodejs-private)/(node|node-private)/pull/\d+

> @ronag would you mind sharing a use case for this method? Does https://nodejs.org/api/n-api.html#napi_create_typedarray work for the use case? > > > > We talked about this in Node-API meeting,...

Creating buffer instances is super slow so I don't think that's an option.

Yes, creating Uint8Arrays is super slow. I'd like to avoid creating 2 for each instance. I have a workaround where I pass 2 array buffers (data and sizes) to js...

So currently I have this situation: 1. For returning buffers from an API. I create two array buffers, one containing all the buffer data and one containing the buffer sizes...