Robert Nagy comments

Results 722 comments of


                                            Robert Nagy

node-api: add napi_create_buffer_from_arraybuffer method

> > I'm happy to jump into a napi working group meeting to further discuss. > > It would be awesome! > > Is [nxtedition/rocks-level#16](https://github.com/nxtedition/rocks-level/pull/16) a benchmark in real world...

node-api: add napi_create_buffer_from_arraybuffer method

Then we might as well call this node_create_buffer?

node-api: add napi_create_buffer_from_arraybuffer method

Here is a possible motivating sample: > Creating buffers from pointers can be slow as each pointer requires a finalizer to be registered. > > ```cpp > static void Finalize(napi_env...

Parcel 2.12.0 malloc(): corrupted top size in Node 22.7.0

If I read this correctly it's `SlowCopy` that has the problem?

Parcel 2.12.0 malloc(): corrupted top size in Node 22.7.0

Who exactly is calling `SlowCopy`? It seems to me that there is a invalid assumption made that the caller to `SlowCopy` validates the range. But I guess that only applies...

Parcel 2.12.0 malloc(): corrupted top size in Node 22.7.0

Can someone who can reproduce check if the following fixes the issue? ``` diff --git a/src/node_buffer.cc b/src/node_buffer.cc index ad6b794cf5d..6b2551c72fe 100644 --- a/src/node_buffer.cc +++ b/src/node_buffer.cc @@ -568,6 +568,9 @@ void StringSlice(const...