undici icon indicating copy to clipboard operation
undici copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

refactor!: drop interceptors

Open metcoder95 opened this issue 1 year ago • 1 comments
trafficstars

  • refactor(#2722)!: Drop Interceptors support (#2754)
  • fix: tweaks

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

  • [ ] I have read and agreed to the Developer's Certificate of Origin
  • [ ] Tested
  • [ ] Benchmarked (optional)
  • [ ] Documented
  • [ ] Review ready
  • [ ] In review
  • [ ] Merge ready

metcoder95 avatar Jul 03 '24 10:07 metcoder95

I'm finding quite more hidden testing situations that might need to be sorted out; the cherry-pick sadly was not completely clean.

metcoder95 avatar Jul 05 '24 10:07 metcoder95

I don't think it's a lot of work to just re do it from beginning?

ronag avatar Jul 06 '24 06:07 ronag

There are a few tests that will be interesting to migrate to the new interceptor setup, but those will take more time so I'd skip them from now.

But the cherry-pick didn't work as I expected, so I'll do it manually instead

metcoder95 avatar Jul 07 '24 13:07 metcoder95

Will create a new one from scratch, the cherry-pick on this one went out of hand

metcoder95 avatar Jul 10 '24 08:07 metcoder95