Ryan Knox comments

Results 80 comments of


                                            Ryan Knox

Removing non doalb call of wrap_canopy_radiation for fates

I think this PR is close to ready. Recent changes: 1) I merge it up to master 2) expanded test coverage per recommendations of SE team about 3 weeks ago...

Removing non doalb call of wrap_canopy_radiation for fates

Below is the test fail list as of f427877. Note that most of these are either expected, or simply missing bases since the tests are new. The only test fail...

Update default FATES parameter file with arctic shrubs and understory allometry update

@peterdschwartz , thanks for working through this with us. I like automatically generating changes to the parameter file, or at least having it scripted, because it removes the human error...

Index out of bound error for `rhol` when FATES patches requested is above 16

My take is that this calculation should be avoided on fates columns and patches since its not relevant or used, perhaps bounding it inside a use_fates or a patch level...

Add call to set FATES control parameters for nutrient supplementation

@glemieux can you take a look at PR #7542 and close this if/when you deem appropriate?

error in errsol computation in BalanceCheckMod reports the wrong albedo values

I think the proposed solution makes sense @mvertens

Pass temperatures to FATES for hardening frost mortality

I'm not sure, we plan to cover this topic in a developer meeting when we have a quorum

ctsm5.4.005: FATES JSON parameter files

This is passing fates test suit on derecho, B4B with base

ctsm5.4.005: FATES JSON parameter files

@ekluzek , the python scripts for fates parameter file modifications, including $FATESDIR/tools/modify_fates_paramfile.py, just use the core libraries now. Derecho had no trouble with modify_fates_paramfile.py. Lets see how izumi does..

ctsm5.4.005: FATES JSON parameter files

Thanks for running those tests @ekluzek , I'll take a look