Ryan Knox comments

Results 80 comments of


                                            Ryan Knox

Enable flexible definitions of plant functional types (PFTs)

ok, I'll take a look @thorntonpe

Enable flexible definitions of plant functional types (PFTs)

I gave a look through the code, somewhere between "thorough" and "almost thorough". I think I came up with some reasonable (and perhaps nit-picky) things to look over. In general,...

Enable flexible definitions of plant functional types (PFTs)

done, thanks @thorntonpe

Update dataset read code (for FATES and non-FATES?) to be compatible with the CMIP7 datasets

@ckoven do we need FATES-side code changes for this, or is this all handled through host-side code?

Add GitHub workflow for Python unit tests

totally awesome feature @samsrabin

Removing non doalb call of wrap_canopy_radiation for fates

@mvdebolskiy , non-downscaled shortwave could just be a a legacy issue, ie we've been using it before a downscale version became available, but I'm just guessing. It has been that...

Removing non doalb call of wrap_canopy_radiation for fates

@ekluzek and @mvdebolskiy can you take a look at the new tests and give feedback corrections? this is not my wheelhouse

Removing non doalb call of wrap_canopy_radiation for fates

Ok, thanks for noting that @mvdebolskiy

Removing non doalb call of wrap_canopy_radiation for fates

@mvdebolskiy could you post the error for the break? I'm wondering if other fixes that have been implemented, such as the cross-referenced PR above may address the problem

Removing non doalb call of wrap_canopy_radiation for fates

@mvdebolskiy your a legend, I'm getting passes in the following test: ERI_D_Ld9.f45_f45_mg37.I2000Clm60Fates.derecho_gnu.clm-FatesColdCamLndTuningMode Should we get this into the integration pipeline soon?