Ryan Knox
Ryan Knox
I believe the default approach is to map to grass for all crops. It makes sense to me to match the photosynthetic pathway as well.
Interesting idea @ckoven
The changes just merged into this branch, in https://github.com/E3SM-Project/E3SM/pull/5106/commits/13d0f5a71ebff055ddd3155a13ebcdd69da43ce7 , were originally overlooked, but nonetheless required for compatibility with fates API 25.
I submitted some updates to @sshu88 's branch to resolve the issues with the fates_eca test. Tests were passing on Cori. Should update once we get it approved and checked.
@rljacob does E3SM have any examples of this strategy employed yet? if so we can try to reproduce this in FATES
needle in one of a thousand haystacks
same, could you post here please?
Fixes: https://github.com/E3SM-Project/E3SM/issues/6186
~~FYI, I still need to test this.~~
I went over the phosphatase changes with @qzhu-lbl , the original author of the phosphatase code. He thought everything looked ok, and recommended we explicitly set the plant biochem pmin...