Reece Hart

Results 228 comments of Reece Hart

I'm open to this idea, but it opens up a much larger issue for a few design principles: - Distinguish parsing (syntactic correctness) from validation. It is intentionally possible (and...

@dhauge: Your very clear report is a model for others to follow. Thanks! I'm inclined to agree with you: objects should be compared exclusively on their members. (Is that what...

Thanks for your willingness to contribute. I don't recall at the moment where or why `__lt__` and `__gt__` are used, so I can't assess whether there will be subtle gotchas...

@sptaylor: I can confirm this bug. I accidentally discovered that this bug doesn't happen if I use a uta_20150827 (discovered through a sloppy copy-paste from old notes). That discovery only...

*Original comment by* **Reece Hart (Bitbucket: [reece](http://bitbucket.org/reece), GitHub: [reece](http://github.com/reece))**: ---------------------------------------- Waiting on https://bitbucket.org/biocommons/uta/issue/161/.

*Original comment by* **Reece Hart (Bitbucket: [reece](http://bitbucket.org/reece), GitHub: [reece](http://github.com/reece))**: ---------------------------------------- BIC alignments are no longer in UTA (uta_20140210). UTA must be updated first (filed https://bitbucket.org/invitae/uta/issue/161 for this). Also, created branch...

*Original comment by* **Rudolph Rico (Bitbucket: [rrico](http://bitbucket.org/rrico), GitHub: [rrico](http://github.com/rrico))**: ---------------------------------------- Test framework in place; can run all but the "IVS" tests once bdi/hgvs update is ready. Tests are in hgvs-test...

See #267, and particularly [this comment](https://github.com/biocommons/hgvs/issues/267#issuecomment-423685415): --- [hgvs-guess-plausible-transcripts]( https://github.com/biocommons/hgvs/blob/master/misc/experimental/hgvs-guess-plausible-transcripts) works like this: ``` (3.6) snafu$ ./misc/experimental/hgvs-guess-plausible-transcripts 'HFE2:c.187_188insGAG' 'TNFRSF1A:c.123T>C' 'TNFRSF1A:n.426T>C' FRSF1A:n.426T>C' HFE2:c.187_188insGAG 5 NM_213653.3:c.187_188insGAG NM_202004.3:c.187_188insGAG NM_145277.4:c.187_188insGAG NM_001316767.1:c.187_188insGAG NM_213652.3:c.187_188insGAG TNFRSF1A:c.123T>C 1 NM_001065.3:c.123T>C...

Right now, it's not possible. But, it's highly desired. https://github.com/biocommons/hgvs/issues/333 has an explanation of why things are the way they are. We can definitely do better here, but it's significant...