Reece Hart comments

Results 228 comments of


                                            Reece Hart

make data provider dependencies optional

*Original comment by* **Reece Hart (Bitbucket: [reece](http://bitbucket.org/reece), GitHub: [reece](http://github.com/reece))**: ---------------------------------------- We have considered this several times, but believe that this is not the right time to remove this dependency. The...

implement tool to identify plausible variants from incomplete/improper variants

*Original comment by* **Reece Hart (Bitbucket: [reece](http://bitbucket.org/reece), GitHub: [reece](http://github.com/reece))**: ---------------------------------------- Depends on #257.

require points or ranges as appropriate for edit type

*Original comment by* **Reece Hart (Bitbucket: [reece](http://bitbucket.org/reece), GitHub: [reece](http://github.com/reece))**: ---------------------------------------- This is doable, but hard. The major challenge is that there are a large number of coordinate types (simple, base-offset...

Support for wildcards lost in the newer versions of hgvs?

Confirmed. Rats. #527, released in hgvs 1.4, eliminated the dependency on biopython which was used solely for the translate function. The replacement translate function doesn't support degenerate codons. The lookup...

Implement hgvs babelfish: hgvs ↔ {vcf, vmc, spdi, beacon, brcaexchange}

See hgvs.extras.babelfish.py (created for #243), but doesn't cover full scope of this issue.

Clarify semantics of NARefAlt and AARefAlt

*Original comment by* **Reece Hart (Bitbucket: [reece](http://bitbucket.org/reece), GitHub: [reece](http://github.com/reece))**: ---------------------------------------- Attaching a patch of preliminary work. This is old and may not be suitable any longer.

Question about HGVS representation for termination retention

For background, see #333 and https://github.com/biocommons/hgvs/issues/2#issuecomment-285511419. So, what's happening here is pretty easy to understand and difficult to fix correctly. As a consequence of the AA grammar (but not the...

Question about HGVS representation for termination retention

Sure, regexp method will work. I considered the same thing as a hack. I might implement that if other solutions are really too onerous.

generate computed variant id

*Original comment by* **Jerry Liu (Bitbucket: [jerryliu2005](http://bitbucket.org/jerryliu2005), GitHub: Unknown)**: ---------------------------------------- This doesn't seem to handle different genome build. I recently saw a global variant id implementation in this BMC bioinfo....

Converge variant models for all sequence types

*Original comment by* **Reece Hart (Bitbucket: [reece](http://bitbucket.org/reece), GitHub: [reece](http://github.com/reece))**: ---------------------------------------- I generally eschew implicit behaviors as well. Like you, I'm committed to parsing being just parsing. The validator does some...