hgvs icon indicating copy to clipboard operation
hgvs copied to clipboard

Clarify semantics of NARefAlt and AARefAlt

Open reece opened this issue 10 years ago • 1 comments

Originally reported by: Reece Hart (Bitbucket: reece, GitHub: reece)


hgvs has two core classes, NARefAlt and AARefAlt that are used to represent SNVs, insertions, deletions, and indels. Although these names made sense when hgvs tried to model ref-alt sequences (in the VCF sense), they now really just model the strings that appear after 'del' or 'ins'. It turns out that RefAlt and DelIns models are deceptively similar and subtly different. This issue must resolve whether to use RefAlt modeling and keep the name, or DelIns modeling and change the name (with appropriate transition).

See DelIns RefAlt Google Spreadsheet for a summary of the similarities and differences with these modeling options.

Also, consider whether p. can use the same model (#333).


  • Bitbucket: https://bitbucket.org/biocommons/hgvs/issue/252

reece avatar Jul 14 '15 04:07 reece

Original comment by Reece Hart (Bitbucket: reece, GitHub: reece):


Attaching a patch of preliminary work. This is old and may not be suitable any longer.

reece avatar Feb 20 '17 23:02 reece

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 29 '24 01:02 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Mar 08 '24 01:03 github-actions[bot]