Ran Shidlansik
Ran Shidlansik
> The first commit is still missing signed-off-by. I seems to be required in every commit. Can you edit it and force-push? I amended the commit so I can't refactor...
> > I amended the commit so I can't refactor the first one any more. not sure how to do that? > > `git rebase -i HEAD~4` lets you edit...
@madolson @hpatro so sorry I missed that one. It is something I already did in Redis OSS and wanted to port it here. rebased and applied @hpatro suggestion.
adding the major-decision-pending even though there is not a breaking change but I think another thread work should be carefully considered
> Let's backport it to all versions, ok? > > Or only backport the `client unblock timeout` case where it could crash? I think cherry picking the exact code would...
> > The fix prevents the crash, but unfortunately it prevents unblocking BLPOP while clients are paused, but this depends on which was first: block or pause. > > ```...
@jjz921024 you will have to sign your commit in order for the DCO to pass.
@valkey-io/core-team since this is an interface/config change, tagged it as major decision. can you please take a look?
> > @valkey-io/core-team since this is an interface/config change, tagged it as major decision. can you please take a look? > > How is this new setting different from `g$lshzxet`...
> BTW, we do have "rename" (or "key modification") events too. Yes we do. we have rename_from and rename_to events