Ran Shidlansik

Results 195 comments of Ran Shidlansik

> @ranshid I just find one issue when I kill the child process by kill -9 child-pid command. > > I run the memtier for heavy write commands, and execute...

> Ah, I didn't think about COMMAND DOCS. When you say docs, I think about the rendered docs on web page and man page. Anyway, COMMAND DOCS is based on...

> An arg with type "pure token" has no value. There's a README for the JSON format now. TIL

Thank you @zuiderkwast for the insights about the args :) I now only added the cancel option and updated the bgsave.json. Since now I think it is no longer a...

> I just noticed, the formulation in replies and log messages should be "background saving" (instead of "background bgsave") to match the existing messages. > > I marked some occurrences...

> @ranshid Do you want to prepare a doc PR, or at least create some issue for it so it's not forgotten? @zuiderkwast Sure will create a doc PR

> > @ranshid Do you want to prepare a doc PR, or at least create some issue for it so it's not forgotten? > > @zuiderkwast Sure will create a...

@naglera IMO just add a hide_user_data parameter to catClientInfoString and pass it on based on the configuration.

closing as was already implemented as part of #837

> I did mark it apparently. It looked like an issue we could add a configuration for. We could also just disconnect the client and stop looping if such an...