valkey-io
Change ascii logo with temporal valkey logo
Maybe I missed but could not locate this has pending pr fix. Currently suggesting temporal logo change.
Please sign-off the commit, also can you add the changes in server.c from this PR to change the server name: https://github.com/valkey-io/valkey/pull/56
This looks great Thanks @ranshid, updated server.c
33926:C 29 Mar 2024 19:08:58.209 * oO0OoO0OoO0Oo Valkey is starting oO0OoO0OoO0Oo
33926:C 29 Mar 2024 19:08:58.209 * Valkey version=255.255.255, bits=64, commit=610614da, modified=0, pid=33926, just started
33926:C 29 Mar 2024 19:08:58.209 # Warning: no config file specified, using the default config. In order to specify a config file use ./src/valkey-server /path/to/redis.conf
33926:M 29 Mar 2024 19:08:58.210 * monotonic clock: POSIX clock_gettime
___ ___
( ) ( )
___ ___ .---. | | | | ___ .--. ___ ___
( )( ) / .-, \ | | | | ( ) / \ ( )( ) Valkey 255.255.255 (610614da/0) 64 bit
| | | | (__) ; | | | | | ' / | .-. ; | | | |
| | | | .'` | | | | |,' / | | | | | | | | Running in standalone mode
| | | | / .'| | | | | . '. | |/ | | ' | | Port: 6379
| | | | | / | | | | | | `. \ | ' _.' ' `-' | PID: 33926
' ' ; ' ; | ; | | | | | \ \ | .'.-. `.__. |
\ `' / ' `-' | | | | | \ . ' `-' / ___ | |
'_.' `.__.'_. (___) (___ ) (___) `.__.' ( )' | https://github.com/valkey-io
; `-' '
.__.'
33926:M 29 Mar 2024 19:08:58.211 * Server initialized
33926:M 29 Mar 2024 19:08:58.211 * Ready to accept connections tcp
^C33926:signal-handler (1711739345) Received SIGINT scheduling shutdown...
33926:M 29 Mar 2024 19:09:06.027 * User requested shutdown...
33926:M 29 Mar 2024 19:09:06.027 * Saving the final RDB snapshot before exiting.
33926:M 29 Mar 2024 19:09:06.031 * DB saved on disk
33926:M 29 Mar 2024 19:09:06.031 # Valkey is now ready to exit, bye bye...
@ranshid You need to add "Signed-off-by: Name <email>" in the commit messages. (It can be done with the -s flag as in git commit -s or by writing it manually.)
@ranshid You need to add "Signed-off-by: Name
" in the commit messages. (It can be done with the -sflag as ingit commit -sor by writing it manually.)
Yep, sorry about that, done now @roshkhatri FYI
The first commit is still missing signed-off-by. I seems to be required in every commit. Can you edit it and force-push?
The first commit is still missing signed-off-by. I seems to be required in every commit. Can you edit it and force-push?
I amended the commit so I can't refactor the first one any more. not sure how to do that?
You might want to squash all you local commits (https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together) and force push again.
I amended the commit so I can't refactor the first one any more. not sure how to do that?
git rebase -i HEAD~4 lets you edit the last 4 commits. Change "pick" to "r" (or "reword") for the commits you need to edit, then save and exit. Next you will be able to exit each of the commit messages.
I amended the commit so I can't refactor the first one any more. not sure how to do that?
git rebase -i HEAD~4lets you edit the last 4 commits. Change "pick" to "r" (or "reword") for the commits you need to edit, then save and exit. Next you will be able to exit each of the commit messages. Done :)
Great. But doesn't it look a little skewed?
Shouldn't it be like this
___ ___
( ) ( )
___ ___ .---. | | | | ___ .--. ___ ___
( )( ) / .-, \ | | | | ( ) / \ ( )( ) Valkey 255.255.255 (610614da/0) 64 bit
| | | | (__) ; | | | | | ' / | .-. ; | | | |
| | | | .'` | | | | |,' / | | | | | | | | Running in standalone mode
| | | | / .'| | | | | . '. | |/ | | ' | | Port: 6379
| | | | | / | | | | | | `. \ | ' _.' ' `-' | PID: 33926
' ' ; ' ; | ; | | | | | \ \ | .'.-. `.__. |
\ `' / ' `-' | | | | | \ . ' `-' / ___ | |
'_.' `.__.'_. (___) (___ ) (___) `.__.' ( )' | https://github.com/valkey-io
; `-' '
.__.'
instead of
___ ___
( ) ( )
___ ___ .---. | | | | ___ .--. ___ ___
( )( ) / .-, \ | | | | ( ) / \ ( )( ) Valkey 255.255.255 (610614da/0) 64 bit
| | | | (__) ; | | | | | ' / | .-. ; | | | |
| | | | .'` | | | | |,' / | | | | | | | | Running in standalone mode
| | | | / .'| | | | | . '. | |/ | | ' | | Port: 6379
| | | | | / | | | | | | `. \ | ' _.' ' `-' | PID: 33926
' ' ; ' ; | ; | | | | | \ \ | .'.-. `.__. |
\ `' / ' `-' | | | | | \ . ' `-' / ___ | |
'_.' `.__.'_. (___) (___ ) (___) `.__.' ( )' | https://github.com/valkey-io
; `-' '
.__.'
I'm guessing the escaped backslashes makes it aligned in source code but not in the output...?
