Ran Shidlansik

Results 195 comments of Ran Shidlansik

I fully agree about the suggestion. some minor comment: >CONFIG GET should return results in the same order as the requested parameters. Alternatively, it could return the results sorted alphabetically...

>I would suggest adding "help wanted" tag so anyone in the community looking to pick up a new problem to solve can review this proposal and take if forward. Yeh...

@naglera Please just add a short description in the top comment so that we do not have a link to a github comment in the git log.

>Currently, Valkey does not provide a way to reliably estimate the size of the entire database. @naglera I think we should carefully define the issues in the current implementation as...

note that this will be handled by @ahmadbelb

@PingXie @madolson In case we will decide to go ahead, we will be happy to take it

I think this state would have been better managed in the client structure. however this would mean much code changes IMO. we should consider prevent multiple debug sessions, but that...

Lets discuss this in the weekly meeting as this is a breaking change proposal.

> This is a lot of work you've done! I've only had time for a partial review today, but I had a few comments/questions so far. The command schema and...

> First comment - 37 changed files??? Dang! you still have another PR in the oven - it might be bigger than this :(