Ran Shidlansik

Results 195 comments of Ran Shidlansik

> `maxmemory-clients 100%` means when all clients' memory reach 100% maxmemory, valkey will disconnect some clients, this config doesn't influence data eviction directly. > > I have always wished that...

> . @ranshid, I think this will solve the fragmentation cost association to usage type. I agree, depending on the complexity of it :)

> I guess a general concern I have is that all of these benchmarks are run on systems that are being stressed. What if the write rate is very low,...

@valkey-io/core-team LGTM but maybe someone has any other concerns?

@poiuj can you please check how on earth did the git misspelled your name on the signoff? the last commiter name is spelled: Vadym Khopty**en**ts Please ammend the commit in...

> LGTM, the top commet does not seem to mention the static buffer in lzf @poiuj lets bring that up in the top comment

> The compression change is mentioned in the top comment: > > > Static buffer for RDB comrpession. > > RDB compression leads to COW events even without any write...

@poiuj one thought I just realized is that we are targetting this as a use when JEMalloc is the allocator right? in case we use libc malloc will this introduce...

> > in case we use libc malloc will this introduce a degradation? > > Noyt sure HOW important it is to avoid degradation since IMO for any operational installation...

> I've run the benchmark with `libc` and there is no effect. It doesn't worth to complicate the code with turning off for other allocators. > > ![3m-fixed-libc](https://private-user-images.githubusercontent.com/1099644/390797943-49e3dba7-c3f4-47af-9ebd-68044cd5f312.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzI4MDE2MTQsIm5iZiI6MTczMjgwMTMxNCwicGF0aCI6Ii8xMDk5NjQ0LzM5MDc5Nzk0My00OWUzZGJhNy1jM2Y0LTQ3YWYtOWViZC02ODA0NGNkNWYzMTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTEyOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDExMjhUMTM0MTU0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGQ0MGZmNjg2MzM0MTUyMTRmZjA4OWM1ZWRmYzBkNjE4NDQ2NmE2YjhkMmQ2NDZhYWEwMmJlZTg0ODBmNGIzMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.3INYJb_hlz1INkVctY2B5M1-eWpyjvoQE-_kuS7n9BA) While I...