Ran Shidlansik

@allenss-amazon I read your suggestion. some small comments: >Clients are easily able to determine which algorithm to use by inspecting the syntax of the field contents -- no client-side state...

I am still providing high level comments (although I do have detailed comments) since IMO we should solve the highlevel first. I think we should have a clear definition of...

> > 4. string-references will NOT be accounted as the entry memory usage in entryMemUsage (I did not notice it is handled, and actually maybe there is a bug there)...

> > From reading the code I see that: > > > > 1. calling entryUpdate with a value which is not a "view" will just assert when the entry...

@yairgott also please make a run through the current documentation and structure ascii and change them accordingly.

Overall the code changes LGTM. NOTE: this might have future conflicts with https://github.com/valkey-io/valkey/issues/2618 @valkey-io/core-team how can we progress the major-decision-pending checkout? does any other maintainer wish to go over and...

> > IMO the open issues + correctness + trivial code refactor can be completed in order to merge it. > > We can consider followup in a different PR...

@yairgott lets just complete the last mile: 1. address @JimB123 last comments 2. lets sync with upstream and resolve the merge conflicts. 3. lets merge the thing!

@JimB123 can you PTAL and qpprove/comment?

Small note: we should definitely take that, but it would probably impact our ability to simply backport fixed to older versions. Maybe we could just backport the function objectGetVal as...