Ran Shidlansik
Ran Shidlansik
note - taking off the run-extra-tests flag, we already have extended tests coverage
> @poiuj Can you run a fully daily CI in your repo, we just want to ensure the test can be passed in every platform (This is only concern from...
I like this proposal very much as it greatly simplifies existing scenarios for clients. I think, though, that it should be made very clear what is the guarantee of this...
@knggk Did we consider ways to avoid calling zmalloc_size on each rax operation? IIRC these can be expensive and we should aim to avoid them. For example It might be...
> > Did we consider ways to avoid calling zmalloc_size on each rax operation? > > But it only happens on rax mutations right? > yes > > try and...
>IMO, we can also accept this PR with zmalloc_size now and allow it to be optimized in the future. Can we open an issue for that then?
>I think this can work, but note that used_memory_thread per thread is a size_t which can wrap around zero. For example, if one thread T1 allocates some memory and another...
I do not think the top comment explains the main issue we are trying to solve here. disk based load on the replica side is meant in order to help...
@valkey-io/core-team this is the change we discussed in the last summit about aligning JEMALLOC vanila. Can you take a look and state if that makes sense before we start diving...
> @ranshid You need to add "Signed-off-by: Name " in the commit messages. (It can be done with the `-s` flag as in `git commit -s` or by writing it...