Nate Lampton

Results 508 comments of Nate Lampton

Thanks @jayelless! Though when testing the latest PR, I now get the toggle for Upload an Image/Select from Library duplicated. ![image](https://user-images.githubusercontent.com/100206/142350537-468f2ae1-43ce-4984-a3e5-0cb23040b19b.png) We might need to make an adjustment to the...

I reviewed the PR at https://github.com/backdrop/backdrop/pull/3680 again and found there were a couple of small display issues. When a validation error was present, the message was showing up alongside the...

I merged https://github.com/backdrop/backdrop/pull/3680 into 1.x and 1.26.x. Thank you @jayelless and @indigoxela for your work on this issue!

Thank everyone! I merged https://github.com/backdrop/backdrop/pull/4620 into 1.x and 1.27.x. This is a great improvement to configuring date fields! https://github.com/backdrop/backdrop/commit/41113e4a7f46c19aca426561e15131cf86e24af0 by @stpaultim, @sudipto68, @BWPanda, @klonos, @kiamlaluno, and @herbdool.

@klonos With your PR applied (or in the sandbox site), making a change won't un-hide the submit button, so it makes it so that you cannot save the View at...

The current PR looks good as-is to solve the missing Cancel button. Maybe we make a follow-up? Besides the redirect location, I'm also inclined to add a status message along...

Thanks @klonos and @herbdool! Sorry this took so long to get reviewed. I merged https://github.com/backdrop/backdrop/pull/3866 into 1.x and 1.25.x.

De-milestoning this as it's been bumped many times.

This implementation looks good to me. We could improve it slightly by checking _which_ dialog got opened. Right now it fires and tries to manipulate the dialog contents regardless of...

https://github.com/backdrop/backdrop/pull/4260 merged into 1.x and 1.23.x. Thanks @argiepiano, @indigoxela, and @klonos!