backdrop-issues
backdrop-issues copied to clipboard
[UX] Date fields: Better help text
It would certainly use some punctuation, and/or be split into two sentences or shortened:
Date objects can be created and cached as date fields are loaded rather than when they are displayed to improve performance.
...something like this perhaps:
Create and cache date objects when date fields are being loaded, rather than when they are being displayed. This improves performance.
PR by @klonos: https://github.com/backdrop/backdrop/pull/3027
...BTW, if this setting improves performance, why isn't it on by default?
Here's another one, for the "Position of date part labels" setting:
The location of date part labels, like "Year", "Month", or "Day" . "Above" displays the label as titles above each date part. "Hidden" doesn't visually label any of the date parts.
For better UX and readability, the last 2 sentences could be moved under each individual option they are referring to.
...there are also tiny typos in the help text for the "Exclude wrapping fieldset" setting:
If using simple inputs such a a single textfield or the date popup, omitting the fieldset may provide simpler styling.
-
such a a
->such as a
-
textfield
->text field
How about this:
Simplify styling when using simple inputs, such as a single text field or the date popup.
...filed a PR for all this: https://github.com/backdrop/backdrop/pull/3027
Before:
After:
These changes look good to me!
We submitted a new pull request based on the feedback of @BWPanda. Please provide your valuable feedback.
(See PR #4028) - This took the work of @klonos and simply added the comments by @BWPanda
Would provide screenshot, but Sandboxes are not working.
Ha, this other duplicate issue was also wanting to update some of this text: https://github.com/backdrop/backdrop-issues/issues/4482 I've closed that one, so we'll work on everything here.
I've made a suggestion in the PR for how to simplify a chunk of code.
Updated PR available for review.
Still needs work.
@sudipto68 Are you still interested in moving forward with this?
New PR based upon the work of @sudipto68. Needs testing and code review.
Atten: @klonos
I left a comment about the tense I would rather use.
@kiamlaluno - Your suggestion made sense to me. I've updated the PR, it's ready for additional review.
I tried to look at the preview site to see the changes, but the site is not even shown. I will try in the morning. (It is 10 PM, here.)
@kiamlaluno Fixed Sandbox!
I created a date field and selected each widget type to see what changed in their settings and the descriptions used for those settings. For what I can see, all has been changed as per issue.
Thank everyone! I merged https://github.com/backdrop/backdrop/pull/4620 into 1.x and 1.27.x. This is a great improvement to configuring date fields!
https://github.com/backdrop/backdrop/commit/41113e4a7f46c19aca426561e15131cf86e24af0 by @stpaultim, @sudipto68, @BWPanda, @klonos, @kiamlaluno, and @herbdool.