Nate Lampton

Results 508 comments of Nate Lampton

https://github.com/backdrop/backdrop/pull/4857 looks good to me. There are a few code style failures but nothing caused specifically by this PR -- in fact it fixes dozens of code style issues. I...

@findlabnet Thanks, I fixed the release description!

Thank you @laryn, @jenlampton, @klonos, and @argiepiano for coordinating today's release!

Merged into 1.x and 1.29.x. Thank you @indigoxela!

This would make a great feature for 1.33.0. Although there is no PR or an advocate, this ability has a lot of prior implementation in contrib and in Drupal that...

@cellear Volunteered during the dev meeting today to be the advocate for this issue. Thank you Luke!

I'm surprised this hasn't gotten more traction. Like @mmichaelis, I'm trying to set more attributes on `` tags than just `href` or boolean `true/false` properties through decorators. Some attribute need...

Thanks @mmichaelis, looks like you've really gone down the rabbit hole on CoreMedia. That will probably be a valuable resource for me. In the issue summary @mmichaelis suggests adding an...

It seems a Drupal contrib module actually implemented almost exactly my second suggestion, extending the link execute event to accept a 3rd argument of arbitrary attributes: https://git.drupalcode.org/project/editor_advanced_link/-/blob/2.x/js/ckeditor5_plugins/editorAdvancedLink/src/editoradvancedlinkediting.js ![image](https://github.com/ckeditor/ckeditor5/assets/100206/d06f6abf-f8d3-4192-90f8-3b63fce5fb6a) Although they...

This is still a desired API feature. Both Drupal and Backdrop are re-implementing a large swath of the `LinkCommand`, while implementing this in `LinkCommand` would take substantially less work comparatively,...