Drupal 7.70-7.75 commits: crossport or mark as NA
- [x] N/A | 8833480c8c | Back to dev
- [x] N/A | 97bd4f7203 | Back to dev.
- [x] committed, but later reverted with 22801c7517 | edb77684bd | Issue #3084935 by kiamlaluno, Taran2L, mcdruid, atheia, Liam Morland: element_children() and DrupalRequestSanitizer::stripDangerousValues() should not use integers as an array
- [x] already in with #4308 - see https://github.com/backdrop/backdrop/commit/5447e13a78c449c0330b9daf9a5c7cd22717a5be#diff-7ab2df427f63f182ab790f5c3668850805fc86ecaaf3e7c6769aa99cd7954efaR474 and https://github.com/backdrop/backdrop/commit/5447e13a78c449c0330b9daf9a5c7cd22717a5be#diff-c4acf33f76932beb676bd6f51fb7f39ad4a2e872c6ca31bafbccc37e607e75e2R316 | b20c7a939a | Issue #3084943 by longwave, Taran2L: Pass parameters as implode($glue, $pieces); reverse order is deprecated
- [x] #4474 | 398945d6db | Issue #3084955 by kiamlaluno, mcdruid, Taran2L: Invalid characters passed for attempted conversion, these have been ignored in _color_unpack()
- [ ] https://github.com/backdrop/backdrop/pull/3627 | ae921e89b1 | Issue #3084961 by mcdruid, Taran2L: Trying to access array offset on value of type null in multiple places in pager.inc
- [x] N/A - this reverted edb77684bd, which was then committed as 175c09b9a2 | 22801c7517 | Revert "Issue #3084935 by kiamlaluno, Taran2L, mcdruid, atheia, Liam Morland: element_children() and DrupalRequestSanitizer::stripDangerousValues() should not use integers as an array"
- [ ] N/A ??? see https://github.com/backdrop/backdrop-issues/issues/5091#issuecomment-841851709 | dc2c0c3257 | Issue #3119875 by mcdruid, Pere Orga, Jasu_M, Heine, Fabianx, David_Rothstein, alexpott, cashwilliams, tim.plunkett, xjm, pwolanin, larowlan, drumm, dsnopek: Add tests for DrupalRequestSanitizer to Drupal 7
- [ ] https://github.com/backdrop/backdrop/pull/3626 | 175c09b9a2 | Issue #3084935 by mcdruid, kiamlaluno, Taran2L, atheia, Liam Morland: Trying to access array offset on value of type int in element_children() and DrupalRequestSanitizer::stripDangerousValues()
- [ ] N/A ??? see https://github.com/backdrop/backdrop-issues/issues/5091#issuecomment-841856571 | 23b14e9dfc | Issue #3084980 by mcdruid, Taran2L: Trying to access array offset on value of type null in path_delete()
- [ ] #xx | 8b0048c67f | Issue #3085088 by mcdruid, Taran2L: menu_get_item() might return FALSE; calling code should take account of this
- [ ] #xx | 942c3944d8 | Issue #3084965 by mcdruid, Taran2L, Fabianx: Trying to access array offset on value of type bool in search_excerpt()
- [ ] #xx | 6c656d75e3 | Issue #3084945 by Taran2L, mcdruid, kiamlaluno: Trying to access array offset on value of type null in _batch_finished()
- [ ] #xx | 460ff5dc3c | Issue #3084953 by Taran2L, kiamlaluno: Trying to access array offset on value of type null in _drupal_build_css_path()
- [ ] #xx | 230c34e7b8 | Issue #3126140 by joseph.olstad, Taran2L, longwave, mcdruid, Ayesh, Fabianx, MustangGB: PHP 7.4 notice in run-tests.sh
- [ ] #xx | e8318811e9 | Issue #3118301 by jacob.embree, joachim: Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4
- [ ] #xx | 78234c808f | Issue #3085163 by mcdruid, Taran2L, Steven Jones: Comment module causes PHP 7.4 Notices on uninstall
- [ ] #xx | 9c181e3915 | Issue #3126133 by Taran2L: NumberFieldTestCase uses non-existent formatter number_float
- [ ] #xx | 30c906a120 | Issue #3126138 by Taran2L: taxonomy_update_7004() uses non-existent widget select
- [ ] #xx | d647c02a70 | Issue #3125824 by Taran2L, mcdruid: Trying to access array offset on value of type null in forum_get_topics()
- [ ] #xx | 4dafac8677 | Issue #3085151 by Taran2L, amoebanath, kiamlaluno, Steven Jones, nishantghetiya, izmeez, mcdruid, Fabianx: field_ui_display_overview_form() expects to always get an array from field_info_formatter_types()
- [ ] #xx | aea09872a3 | Issue #3087121 by Taran2L, kiamlaluno, mcdruid, klausi, Fabianx, Steven Jones, MustangGB: SystemValidTokenTest is failing on PHP 7.4 when drupal_hmac_base64() is called incorrectly
- [x] N/A | 36289d8ef8 | Back to dev.
- [ ] #xx | 7430460c2c | Issue #3085148 by Taran2L, mcdruid, kiamlaluno: Fix field_test_field_attach_delete_bundle()
- [ ] #xx | 9ed3f679ef | Issue #2788565 by lhuria94, shashikant_chauhan, sjerdo, ravikk-drupal, joachim, longwave: sample code for callback_filter_process() and callback_filter_prepare() should not include deprecated regex option
- [ ] #xx | b79f40a8c6 | Issue #3085098 by longwave, Taran2L, sjerdo, Dinesh18, oliver.hader: PHP Phar Stream Wrapper should be updated (PHP7.4 support, drop fileinfo dependency)
- [ ] #xx | 18d4dd381d | Issue #3126312 by joseph.olstad, ravikk-drupal, mcdruid, mohangathala, jungle, Taran2L, Fabianx: Since PHP7 func_get_args() no longer reports the original value as passed to a parameter, so call it early
- [ ] #xx | 4e87afee1e | Issue #3143016 by dsnopek, mcdruid, effulgentsia, philltran, Fabianx, lauriii: Chrome 83 cancels jquery.form ajax requests over https
- [x] N/A | 4558afc32e | Drupal 7.71
- [ ] #xx | f0027e05b4 | SA-CORE-2020-004 by samuel.mortenson, DorTumarkin, greggles, xjm, larowlan, webchick, pwolanin, dawehner, mcdruid, alexpott, dsnopek
- [x] N/A | 91f479be93 | Drupal 7.72
- [ ] #xx | cd3721550d | SA-CORE-2020-007 by samuel.mortenson, nod_, larowlan, dsnopek, catch, effulgentsia, mcdruid
- [x] N/A | cbd404ebdd | Drupal 7.73
- [ ] #xx | 0263ea89cf | SA-CORE-2020-012 by ufku, mrf, fgm, samuel.mortenson, dww, Heine, mlhess, David_Rothstein, pwolanin, xjm, fgm, stefan.r, dsnopek, rickmanelius, David Strauss, tedbow, alexpott, dww, larowlan, kim.pepper, Wim Leers, quicksketch, mcdruid, Fabianx, effulgentsia, drumm, pandaski, Mixologic
- [x] N/A | f941729699 | Drupal 7.74
- [ ] #xx | 6435c5fabb | SA-CORE-2020-013 by luke.stewart, xjm, larowlan, mcdruid, drumm, mlhess
- [x] N/A | 98b9dd73fb | Drupal 7.75
Generated with:
git log 7.70..7.75 --reverse --no-merges --pretty=format:"- [ ] #xx | [%h](https://cgit.drupalcode.org/drupal/commit/?id=%H) | [%s](http://drupal.org/node/)"
Issue #3119875: Add tests for DrupalRequestSanitizer to Drupal 7 has basically added https://git.drupalcode.org/project/drupal/-/blob/7.x/includes/request-sanitizer.inc with dc2c0c3257, which is meant to be the same as the tests we've added with https://github.com/backdrop/backdrop/commit/ae93eccb2aafb58e887ec5acf4c46b53b6963f67#diff-4fa64da2406497325271e58ee7eb243dfbef3ec876715b8953859490ae357242R2507.
At first look, it seems that our tests might be slightly less, but I could be wrong about it. @quicksketch or anyone else should confirm.
I think that https://git.drupalcode.org/project/drupal/commit/23b14e9dfc87bff0429a2d2e6470475e48de4d30 is N/A to Backdrop. We have https://github.com/backdrop/backdrop/commit/62a34fcfd736d43395b59e2fd59f830c63601241in place since 2016 + tests for it, and no problems reported.
I could be wrong though, so need someone to double-check and confirm.
@bugfolder this is the list :)
De-milestoning this as it's been bumped many times.