Nate Lampton
Nate Lampton
This looks good to me. We need to update the `@since` line for the version of Backdrop we're targeting, but I can do that on merge. I would expect this...
I read through the PR and there are actually only 3 changed translations, all of which are administrative-only: This change in Contact module: `[email protected]` => `[email protected]` And these two strings...
I have merged this into 1.x and 1.26.x! Yay, this is great. Thanks to everyone in helping remove this language. The final solution is also backwards-compatible until 2.x, when the...
I found a variable name typo that might cause undefined variable notices: https://github.com/backdrop/backdrop-issues/issues/6338. Simple problem for which I filed a PR.
Amazing @opi! Love it! We might consider adding `StyleLint` to our build process to validate code style. One issue I saw repeated in the CSS (not a very big deal)...
Actually the new-lines added throughout Basis are quite excessive. We need these to be fixed before merging.
Thanks @indigoxela and @yorkshire-pudding! I'd like to give it more extensive review. This looks like it could use additions to automated testing. I see that the label checking was updated,...
Thanks @herbdool and @yorkshire-pudding for pushing this one to the finish! I merged https://github.com/backdrop/backdrop/pull/3712 into 1.x and 1.27.x. Thanks @jenlampton, @klonos, @docwilmot, @stpaultim, and @olafgrabienski for the work on this...
I left a review where I found a few issues: https://github.com/backdrop/backdrop/pull/3696#pullrequestreview-775772283 Overall though, I'm not totally sure this is the right approach. If arbitrary paths can be specified that create...
> I find that commenting out the ajax command to replace the form in the function filter_format_editor_dialog_save solves the problem in this instance. The question is what other effects does...