Nate Lampton

Results 508 comments of Nate Lampton

I'm not sure this would be easy. Blocks right now either have "required context" or none at all. So if we make `node` a required context, the "BlockText" block would...

For reference here's what Views does (which is similar functionality): ![image](https://user-images.githubusercontent.com/100206/92793890-b740a380-f363-11ea-8c72-ee227860ab61.png) Though IMO there's very little about the Views approach we'd want to copy.

Yeah, @jenlampton I think you need to re-push this branch? Also I think there's a missing check_plain(): https://github.com/backdrop/backdrop/pull/2960#discussion_r785254206

@jenlampton Sorry! I think there's one more place that needs a `check_plain()`: https://github.com/backdrop/backdrop/pull/2960/files#r793279222

There's an accidental revert of some terminology in the PR: https://github.com/backdrop/backdrop/pull/2960#pullrequestreview-951134213 > Should the "File URL" be linkified? I agree with this, seems weird to display a URL but not...

I filed a PR against @jenlampton's PR at https://github.com/jenlampton/backdrop/pull/15 that makes the URL clickable and reverts the terminology regressions. https://github.com/jenlampton/backdrop/pull/15

I found some issues in the current implementation where "replica" was accidentally used in Views config values instead of "default"; that would cause a setting to not be respected. I...

The changed code looks great, thanks @herbdool for coming in and fixing the use of `.on()` in the JavaScript. There's a legit failing test across all versions of PHP: ```...

Thanks @herbdool! I merged https://github.com/backdrop/backdrop/pull/4619 into 1.x and this is the first issue in the new 1.27.x branch to be fixed. Thanks @jenlampton, @stpaultim, @laryn, @olafgrabienski, and @klonos!

I went ahead and closed https://github.com/backdrop/backdrop/pull/3177 since it's the older PR and improvements have been made in the second PR by @herbdool. I resolved the conflicts in https://github.com/backdrop/backdrop/pull/3892 so this...