Patrick Ohly

Results 1004 comments of Patrick Ohly

/test pull-kubernetes-kind-dra That job is from https://github.com/pohly/kubernetes/pull/33.

/test pull-kubernetes-kind-dra

/test pull-kubernetes-kind-dra

/test pull-kubernetes-kind-dra

> are you planning to expose the allocated device in the PodResourcesServer [1] same as device plugin, cpu and memory managers are doing? No, there are no such plans. I'm...

The YAML files were (are) slightly outdated: `parameters:` must be replaced by `parametersRef:`. That change came up after reviewing the API guidelines and was made to the API implementation, but...

/test pull-kubernetes-unit TestConnectionPings failed - seems unrelated.

/test pull-kubernetes-integration Unrelated (?) test flake: `k8s.io/kubernetes/test/integration/scheduler/preemption: TestNominatedNodeCleanUp/mid-priority_pod_preempts_low-priority_pod,_followed_by_a_high-priority_pod_without_additional_preemption` Update: this was related to the PR after all. The PostFilter implementation must return UnschedulableAndUnresolvable when the plugin is disabled. Fixed.

> can you add a scheduler integration test? https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/3063-dynamic-resource-allocation#integration-tests I think we said earlier that this would only be needed for beta. The E2E tests that we have and that...

I had to rebase because of a merge conflict. The current branch includes the changes from the API review in https://github.com/kubernetes/kubernetes/pull/112981 (for example, "ShareableResource" -> "Shareable"). It also include the...