Mathias Agopian
Mathias Agopian
https://crbug.com/1348017
What if you use ssao or fxaa instead of mssa? Does it make it work too?
I don't think emscripten even supports fences. What do you mean by "We are experiencing synchronization issues".
@shubhamgarg21 I think you can call `Engine::pumpMessageQueues()` instead of `flush` after `execute`.
Ok I looked at the code and as it stands now you must call beginFrame/endFrame for the previous frames callback to trigger in the single-threaded environnement. I'll try to see...
`{ -1, -1 ,0 }` is not a unit vector for the light direction. Can you share the project?
Or maybe we could do the conversion in the shader for one of the input when they are mixed. With spec constants, this could even be "free" when both match.
maybe in the meantime, we could do something to avoid the crash (and I guess get bad roughnessMap instead), and downgrade this bug to "correctness" from "crash"?
Thanks for the PR I need to maul over it for a while. My areas of concerns: - we have an extra pass (in the case of SSAO enabled, we...
> Hi @pixelflinger! What are your thoughts on this pull request? I'm ready to attempt adding more changes if needed. We're very sorry for the delay, we've been, and still...