spring-boot icon indicating copy to clipboard operation
spring-boot copied to clipboard

Support Otlp Tracing's GRPC port from service connections

Open eddumelendez opened this issue 1 year ago • 4 comments

Otlp Tracing's exporter is configured using Transport. Current support for service connections read the mapped port for HTTP transport 4318. This commits adds support to read port for GRPC transport 4317.

eddumelendez avatar Jul 05 '24 15:07 eddumelendez

Thanks for the PR, @eddumelendez. I'm not sure what the answer is, but this doesn't feel quite right to me. I don't think the connection details should have a separate method for the GRPC endpoint. Ideally, the existing getUrl() method would return the URL that's appropriate for the configured transport but I'm not yet sure how we could achieve that.

wilkinsona avatar Jul 05 '24 16:07 wilkinsona

Hi @wilkinsona, yes, I agree. I think that's the only way I was able to achieve it. Looking forward for any hint to update the PR.

eddumelendez avatar Jul 05 '24 16:07 eddumelendez

We discussed this today and we think we might be able to pass the Transport to a OtlpTracingConnectionDetails.getUrl(...) method. We can experiment with this before we merge the PR.

philwebb avatar Jul 10 '24 14:07 philwebb

Placing on hold as we'd like to spend a bit of time thinking through our gRPC support across logs, metrics, and tracing.

wilkinsona avatar Jul 11 '24 17:07 wilkinsona

Thanks!

I've modified OtlpTracingConnectionDetails to add a String getUrl(Transport transport) method.

mhalbritter avatar Sep 06 '24 11:09 mhalbritter