Javier Spagnoletti

Results 117 comments of Javier Spagnoletti

I'll be AFK until the next year (sounds a lot, but we are almost there :stuck_out_tongue:)

>I think README need an alert on that. Official version (no alpha or beta) is published mentionning compability with doctrine/dbal v4 which is not totally true. I totally agree. See...

Hi :wave: As I'm not sure if the proposed implementation is acceptable or it is pointing to the right direction, I'd love to receive some feedback before going further. Thank...

Related to sonata-project/exporter#532.

Thanks for your feedback! I'm not familiarized with the parser or the tokenizer. Do you think the approach should replace the tokens at `PHPTokenizerInternal::substituteTokens()` or should I play with `Tokenizer::peek()`...

Regarding the class instantiation parsing, do you think is a good idea to fake the `ASTAllocationExpression` by adding the `new` keyword for the attribute names? In that case, I guess...

>@phansys let me know if you want help with rebasing or some other aspects of this PR. Thank you @AJenbo. I must dive into this subject again. IIRC, the main...

I am closing this issue as the fix for this was released at [v3.21.0](https://github.com/doctrine-extensions/DoctrineExtensions/releases/tag/v3.21.0). Thank you!