DoctrineExtensions icon indicating copy to clipboard operation
DoctrineExtensions copied to clipboard

Add generics for the event subscriber configuration arrays and adapters

Open mbabker opened this issue 1 year ago • 1 comments

Extracted from #2825

There is already an attempt to document the returned configs and event adapters in the event subscribers using @method annotations, but this can be quirky with IDEs (@method is read as a virtual method as an example) and there were still some baseline PHPStan issues from the existing setup. This PR formalizes that through generics by providing templates for the config and adapter interfaces and updating each listener to fill those in (where that info already exists, there are a few extensions where a type for the config still needs to be generated so a generic array is still specified).

mbabker avatar Aug 18 '24 00:08 mbabker

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.84%. Comparing base (0632ab1) to head (b44e39b). Report is 69 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2851      +/-   ##
==========================================
+ Coverage   78.75%   78.84%   +0.09%     
==========================================
  Files         163      167       +4     
  Lines        8593     8638      +45     
==========================================
+ Hits         6767     6811      +44     
- Misses       1826     1827       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 18 '24 00:08 codecov[bot]

Thanks @mbabker!

phansys avatar Oct 06 '24 22:10 phansys