Javier Spagnoletti

Results 117 comments of Javier Spagnoletti

>As above, this is impossible. Count how many optional extensions PHP has, call it N, and try to launch 2^N CI instances. I don't know why we should check this...

I hope this feature or some parts of it can be addressed in the stable branch first. I'll try to take a look.

This is a follow up of this comment: https://github.com/Azure/azure-sdk-for-php/issues/926#issuecomment-391141277. @sergey-shandar, @yaqiyang; is the [`arm`](https://github.com/Azure/azure-sdk-for-php/tree/arm) branch intended to be part of a new release of this library (mean, v2 by instance)...

If this is a problem, I think the issue is in the way the comparison is implemented. By instance, using the locale "es_ES" (Spanish from Spain) the month representation is...

You could check if the right "[locale](http://eonasdan.github.io/bootstrap-datetimepicker/#using-locales)" option is passed to [`Sonata\Form\Type\BasePickerType`](https://github.com/sonata-project/form-extensions/blob/206c7024b9f461a11610885a99eab2dbd9b47fc2/src/Type/BasePickerType.php#L113-L146): ```php $view->vars['dp_options'] = $dpOptions; ``` since this option is intended to provide the "[locale](https://github.com/sonata-project/form-extensions/blob/206c7024b9f461a11610885a99eab2dbd9b47fc2/src/Bridge/Symfony/Resources/views/Form/datepicker.html.twig#L34 )" option in the...

Thanks for your first contribution @DennisdeBest! :confetti_ball: Could you please rebase in order to fix the failed checks in the CI pipeline?

Could not we rely on an interface for the `setCacheItemPool()` method (maybe we should create one if it does not exist) instead of relying on `method_exists(MappedEventSubscriber::class, 'setCacheItemPool')`?

I agree with the resulting feature, but I think we should consider the current implementation we have around the `global_search` option in the field description.

The prevention is done in order to avoid the object to accept a set of inconsistent values, regardless who is writing them. In my specific use case, the situation was...

For those who felt confused about the motivation for these changes, I've added a more detailed example trying to explain how composer works and what my concerns are. Thank you...