Javier Spagnoletti comments

Results 117 comments of


                                            Javier Spagnoletti

[Tree] Add pre-order and level-order traversals

>IMO, the second one it the best answer since we improve code without any BC break. Before doing any commit, is it OK for you @phansys ? LGTM.

[Loggable] Support embeddable xml mapping

Hi @pierre-H! You should add a changelog note with the related changes ([ref.](https://github.com/doctrine-extensions/DoctrineExtensions/blob/main/CONTRIBUTING.md#changelog)) and the required tests to cover this feature.

Deprecate the annotation reader being allowed to be any object

Thanks @mbabker!

Updated composer.json

Removed `target-dir` setting. ping @jmathai @SvenRtbg

Convert resources to objects

See php/php-tasks#6.

Replace `<literal>` nodes with `<constant>` for constants

Great! Let me inherit these changes here and mark the other PR in a TO-DO list in order to make the dependency explicit.

Replace `<literal>` nodes with `<constant>` for constants

>Also it would be nice to fix the whitespaces in another PR that one can skip-revcheck as those clutter the PR. Whitespace changes were reverted :+1:

Replace `<literal>` nodes with `<constant>` for constants

Rebased.

Replace `<literal>` nodes with `<constant>` for constants

I think these are missing cases @haszi. Thank you for pointing. Let me check if I can find a consistent way to catch them and I'll update the PR.

Replace `<literal>` nodes with `<constant>` for constants

The cases using the `_XXX` suffix were addressed.