Javier Spagnoletti

Results 117 comments of Javier Spagnoletti

>I can't see any conflicts, though. Don't you see this message? >This branch cannot be rebased due to conflicts ![image](https://user-images.githubusercontent.com/1231441/145100799-f76c9b6a-e470-4592-bf3d-add857484969.png)

>OK done @phansys. Just wanted to ask if you could also check that I did not reintroduce some of the old issues? I'm not aware about the related issues, as...

>@phansys I was just referring to the issues you pointed out in your reviews. To make sure I did not reintroduce one of them while rebasing. Oh, don't worry about...

>I am currently lost as how to prevent the deprecation reports by PHPUnit which lead to the failed tests. I guess you should add the new `$flatten` argument in the...

>Also I have no idea why the PHPStan error in Geo.php suddenly appears. Regarding this, I think we could safely remove that ignored error from the baseline (see https://phpstan.org/r/b92f2814-4530-4cda-aaf4-236c6c3eaadf). https://github.com/doctrine-extensions/DoctrineExtensions/blob/118a001c1d0855df5c9ee35c1588d80a4d517d97/phpstan-baseline.neon#L808-L812

The issues reported by PHPStan should be resolved by #2475.

@samuel4x4, thank you so much for this feature! Could you please add tests for this change and a changelog note?

Thank you for reporting the issue @signmeuptwice. Could you please check if the same version of this package is working fine in your project previous to the upgrade?

>Nothing has changed here. The tests and docs belong in the release on principle: end-users need them. The whole purpose of the tests is to ensure that the thing runs...

>But that's not true! The CI tests only two specific configurations. There's a huge (combinatorial, impossible to try them all) number of valid configurations. All matching versions of all dependencies,...