Javier Spagnoletti comments

Results 117 comments of


                                            Javier Spagnoletti

[Repo] Codecov not uploading on push to `main`

Thank you so much!

Migration to 3.20 breaks our test suite

I am closing this issue as the fix for this was released at [v3.21.0](https://github.com/doctrine-extensions/DoctrineExtensions/releases/tag/v3.21.0). Thank you!

Partial DBAL 4.x support

Thank you @mbabker!

Partial DBAL 4.x support

>Any plans to be merged soon? Thanks Sorry for the delay. [`3.17.0`](https://github.com/doctrine-extensions/DoctrineExtensions/releases/tag/v3.17.0) was released, including this PR.

Deprecate annotation-specific properties in the Sluggable extension annotation/attribute classes

Thank you @mbabker!

Add test for `MethodNode::isDeclaration()`

Do you know if there is any init process or something else I might be missing? I suspect that the related ASTs for the `ClassNode` containing the `MethodNode` (parent classes,...

Add test for `MethodNode::isDeclaration()`

> i would try targeting 3.x instead, things are simpler, cleaner and you get full phpstan checks on your changes. I'll try to create a new PR against 3.x, thanks...

Add test for `MethodNode::isDeclaration()`

> Are you running the checks locally? Some will only run when others pass but can provide valuable debug info No, I wasn't checking locally based on the pain generated...

Omit unused formal parameters when the method uses `\Override` attribute

If there is no hint to replace the reflection API with an AST, I think this PR is RTM.

Omit unused formal parameters when the method uses `\Override` attribute

After the addition of more tests, I can confirm the `\Override` attribute or the `@inheritDoc` annotation are not required to detect inheritance if the parent classes are declared in the...