Javier Spagnoletti

Results 117 comments of Javier Spagnoletti

IMHO, #512 is a good example of what happen when a package trust on an unstable dependency, and it gets even worse when that dependency is allowed blindly, like in...

Thank you Johannes. The message was updated according your suggestion.

Thanks for your feedback Junio. Given your input, I think we should improve the way or the cases we are testing. I try to share a brief about PHP methods:...

[v3.10.0](https://github.com/doctrine-extensions/DoctrineExtensions/releases/tag/v3.10.0) was released. `/cc` @core23.

I agree. We should have a more consistent mechanism to compose the required combination between formatters and writers. Currently, we have cases like #648, where we are using the source...

>@phansys are you able to resolve the merge conflicts please? Since this PR is almost 5 years old, I guess I must also update the behavior on some checks, since...

>I don't really care much about those, so if you prefer another one, I can change them. For lack of a better example, I think [this one](https://github.com/aws/aws-sdk-php/blob/5791e496e3fc0847f40c86515ed8659b0ecd5991/src/S3/S3Client.php#L297-L345) a bit tidier.

Thanks @pmishev. As I mentioned, I don't want to block this PR. Regarding your points, I guess we can keep the `@param` tag if it adds some value, like `@param...

I guess we can merge this PR before the new release, as it is not narrowing an existing dependency or adding new ones. :+1: