Robert Pająk

Results 726 comments of Robert Pająk
trafficstars

> Does that apply here as well? No as this instrumentation library does not handle panics and does not call https://pkg.go.dev/go.opentelemetry.io/otel/trace#Span.RecordError. Anyway, I am really grateful for your positive attitude...

@scorpionknifes You are assigned. I suggest also looking at https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/bridges/otelslog as reference.

@scorpionknifes, I added "TODO" steps to the issue description

@scorpionknifes, I think that at the point we can add `otellogr` to published modules. I find it safer to track https://github.com/open-telemetry/opentelemetry-go-contrib/pull/5357#discussion_r1680750975 as a separate issue. We can even postpone its...

@MrAlias, I am removing it from [Go: Logs (GA)](https://github.com/orgs/open-telemetry/projects/43) as I do not see it as a GA blocker.

You need to override the implementation of `OnForceFlush`: https://github.com/open-telemetry/opentelemetry-dotnet/blob/fe78453c03feb8dbe506b2a0284312bdfa1367c5/src/OpenTelemetry/BaseExporter.cs#L135-L154

Also this is just a "base implementation" and it is up to the "concrete implementation" to do its best to adhere to the specification. Doing any logic would be a...

Also [the docs](https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/trace/extending-the-sdk#exporter) says that one can implement `OnForceFlush`. @Paulskit Do you see any area of improvement or can we close the issue?

For Go (developed mainly by @codeboten): - contrib package: `go.opentelemetry.io/contrib/config` - docs: https://pkg.go.dev/go.opentelemetry.io/contrib/config - otel-config version: 0.2.0 - Status: Development - notes: No examples, does not do env var substitution,...

There is a WIP PR for .NET Automatic Instrumentation: - https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/4270 CC @ysolomchenko