Robert Pająk
Robert Pająk
Please make sure to add benchmarks to the PRs which are meant to improve performance. You can also consider creating separate PRs that would contain just benchmarks.
Please use https://pkg.go.dev/golang.org/x/perf/cmd/benchstat to show the performance improvement (between main and this branch) in the PR description.
Can you please fix the build? See: https://github.com/open-telemetry/opentelemetry-go-contrib/actions/runs/9854291298/job/27206720483?pr=5719
@prestonvasquez, can you sync the branch with main? @open-telemetry/go-approvers, last call for review. I plan to merge this PR tomorrow unless nobody adds comments.
Can you add tests that verify that the YAML/JSON files are parsed (thanks to the tags) as expected?
Closing per https://github.com/open-telemetry/opentelemetry-go-contrib/pull/5251#pullrequestreview-1962694859
What about `CODEOWNERS`? Who will maintain the new bridge? More: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CONTRIBUTING.md#code-owners
@iancharters, the module is not released. It is your own responsibility to use pseudo versions of in-development modules.
> These calls are made from stdlib and I don't know the condition when the specific call order appears. I think the main usage of `httptrace.ClientTrace` is here: https://github.com/golang/go/blob/master/src/net/http/transport.go
Changing this PR to draft per https://github.com/open-telemetry/opentelemetry-go-contrib/pull/5357#issuecomment-2257740377. Use this PR as a reference for new PRs.