Robert Pająk

Results 727 comments of Robert Pająk
trafficstars

Related to: - https://github.com/open-telemetry/opentelemetry-go/issues/4534

@mikeblum, I think that you need to implement `func (j *AttributeNameValue) UnmarshalYAML(unmarshal func(interface{}) error) error` and `func (j *AttributeNameValue) MarshalJSON() ([]byte, error)` methods. Look at `config_json.go` and `config_yaml.go` for examples.

```go select { case

@tmc, do you plan to move this forward or can we close the PR?

> These are domain/service specific attributes in the context. If there are domain/service specific attributes than maybe you can create domain/service specific metrics that would use these attributes instead asking...

> IIUC you're saying that RPC metrics must never have any attributes other than those listed in the [semantic conventions](https://opentelemetry.io/docs/specs/semconv/rpc/rpc-metrics/#attributes)? I do understand that there are use cases where users...

> Are they meant to be the one stop shop where we can come and get the officially maintained instrumentation from OTEL? This. I want to get a full understanding...

Based on today's OTel Spec SIG meeting: Adding custom hooks for instrumentation library which are acceptable especially given they have access to contextual information that is not accessible to the...

> Does that mean this PR is good to continue progressing with? I'm on vacation atm but I can pick it back up next week if so. This > >...