Robert Pająk

Results 363 comments of Robert Pająk

> If the value was not specified, SDKs MUST fallback to `unknown_service:` concatenated with [`process.executable.name`](process.md#process), e.g. `unknown_service:bash` As far as I understand we would first need to propose a change...

@julealgon None that I am aware of. Feel free to create a PR/issue in [OTel specification](https://github.com/open-telemetry/opentelemetry-specification) or join their SIG meeting (more info [here](https://github.com/open-telemetry/community#specification-sigs)).

I just quickly scrolled through the issue and it looks related to this one https://github.com/open-telemetry/opentelemetry-dotnet/issues/2781

You can create your own `EventListener` for `"OpenTelemetry-Exporter-OpenTelemetryProtocol"` EventSource. [Here](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/ac0ddf9a71d3883b736a60ac14bd258cff6ebf41/src/OpenTelemetry.AutoInstrumentation/Diagnostics/SdkSelfDiagnosticsEventListener.cs) is an example of how OTel .NET AutoInstr captures OTel .NET SDK events for logging purposes. _I think it is...

> It is not recommended to attempt any client-side parsing of db.statement just to get these properties, they should only be used if the library being instrumented already provides them....

For some libraries (e.g. ORM) it would be fine. But with SqlClient (which is very low level) I do not think it is possible without parsing the statements which is...

TL;DR; **Yes.** In case of problems look at the [troubleshooting](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docs/troubleshooting.md) docs. The automatic instrumentation binaries should contain all needed references. They should be automatically loaded when needed. However, there are...

I changed the title as I found it misleading. THe information regarding the instrumentation libraries versions is somehow documented here: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/4fa14e4ddb7e1daeee42071f6d5f2a49040d0852/docs/README.md?plain=1#L25-L27

> based on my experience with these usages, it gets harder and harder to keep track of which parameters are being used over time Do you mean that it is...

@pjanotti Do you expect any more tests than we have right now (mostly thanks to https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/845)? I think we have integration tests for testing these classes - anything other than...