opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Add logr log bridge

Open pellared opened this issue 1 year ago • 3 comments

Add logr.LogSink log bridge.

Prototype implementation: https://github.com/pellared/opentelemetry-go/blob/147762ffb5c4394417b3f973274cc570723db79b/log/internal/logr.go

TODO:

  • [ ] Implementation: (draft: https://github.com/open-telemetry/opentelemetry-go-contrib/pull/5357)
  • [ ] Benchmarks
  • [ ] Add to published modules
  • [ ] Add to OpenTelemetry Registry. Example PR: https://github.com/open-telemetry/opentelemetry.io/pull/4857
  • [ ] Handle key-naming conventions

pellared avatar Mar 01 '24 13:03 pellared

Keen to pick this one up

scorpionknifes avatar Apr 03 '24 09:04 scorpionknifes

@scorpionknifes You are assigned. I suggest also looking at https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/bridges/otelslog as reference.

pellared avatar Apr 03 '24 09:04 pellared

@scorpionknifes, I added "TODO" steps to the issue description

pellared avatar Jul 25 '24 15:07 pellared

@scorpionknifes, I think that at the point we can add otellogr to published modules.

I find it safer to track https://github.com/open-telemetry/opentelemetry-go-contrib/pull/5357#discussion_r1680750975 as a separate issue. We can even postpone its resolution until we get community feedback if it actually needed.

pellared avatar Nov 26 '24 09:11 pellared