Robert Pająk
Robert Pająk
@khushijain21 is working on it.
1. ~~We do not need to implement zapcore.Encoder as we are providing a zapcore.Core~~ 2. You can first implement `Write` and then `With` method as separate PRs 3. You can...
From https://github.com/open-telemetry/opentelemetry-go-contrib/pull/5251#pullrequestreview-1962694859: > I am not sure if it is good to allow users to do that much. > > The user can e.g. change the span kind using https://pkg.go.dev/go.opentelemetry.io/otel/trace#WithSpanKind...
I added a comment here: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5088#issuecomment-2499904424 @asecondo, I am changing this PR to draft as it is not in a mergeable state there are no approvals.
CC @mx-psi
> > The biggest challenge would be to determine when a new record starts and ends. By default we could be say that log records are split by EOL >...
@pohly, so https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5192 is what you need? There is already a PR open (https://github.com/open-telemetry/opentelemetry-go-contrib/pull/5357), but I had no time to look at it.
I made a quick analysis. There need to be different log bridges for `klog` and `log` because they are using the passed `io.Writer` differently. For `log` it should be easy...
Closing this one. I created https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5963
> How did you configure `klog`? My bad, I looked at `v1` 🤦 Still there would need to be a bridge for each logger... However, as you [mentioned earlier](https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5425#issuecomment-2074800905) an...