Pascal Roth comments

Results 79 comments of


                                            Pascal Roth

Transfer tests from unittest to pytest

@jsmith-bdai thanks for the feedback, all should be adjusted now

Adds option to define the concatenation dimension in the `ObservationManager` and change counter update in `CommandManager`

@kellyguo11 and @jsmith-bdai this also fixes the `test_serialize_term` in the `test_observation_manager.py` which was still on unittest

Transfer tests from unittest to pytest

merged with #2034

Moves meshes in the `RayCaster` to classvar to be shared between sensors

lets wait with a merge, just making some tests for the ray_caster to make sure that the new classvar is cleared correclty

Moves meshes in the `RayCaster` to classvar to be shared between sensors

@Mayankm96 ready for a review, now the raycaster also has a first set of basic tests. IMPORTANT: the test already run with pytest, commented out part at the top is...

Moves meshes in the `RayCaster` to classvar to be shared between sensors

so regarding the tests: - test_ray_caster.py: fail is expected as written in pytest (not sure why our unittest framework even catches that one) - test_tiled_camera.py and test_contact_sensor.py fail but are...

Moves meshes in the `RayCaster` to classvar to be shared between sensors

Not sure, will have to check today

Moves meshes in the `RayCaster` to classvar to be shared between sensors

So, the tests are passing locally! When investigating the log, then it complains about reaching a recusion depth during the raycasting. ``` source/isaaclab/isaaclab/utils/configclass.py:282: in _validate missing_fields.extend(_validate(value, prefix=current_path)) _ _ _...

Moves meshes in the `RayCaster` to classvar to be shared between sensors

I tend to agree, we can put some debug statements all over the code and see if we find something haha

Moves meshes in the `RayCaster` to classvar to be shared between sensors

now included in #3298