IsaacLab icon indicating copy to clipboard operation
IsaacLab copied to clipboard

Adds option to define the concatenation dimension in the `ObservationManager` and change counter update in `CommandManager`

Open pascal-roth opened this issue 8 months ago • 1 comments

Description

Added support for concatenation of observations along different dimensions in ObservationManager.

Updates the position where the command counter is increased to allow checking for reset environments in the resample call of the CommandManager

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • [x] I have run the pre-commit checks with ./isaaclab.sh --format
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • [x] I have added my name to the CONTRIBUTORS.md or my name already exists there

pascal-roth avatar Apr 28 '25 09:04 pascal-roth

@pascal-roth what do you think of this compared to (or in addition to): https://github.com/isaac-sim/IsaacLab/pull/1958

jtigue-bdai avatar Apr 29 '25 20:04 jtigue-bdai

@kellyguo11 and @jsmith-bdai this also fixes the test_serialize_term in the test_observation_manager.py which was still on unittest

pascal-roth avatar May 16 '25 11:05 pascal-roth