Nicolas Grekas comments

Results 634 comments of


                                            Nicolas Grekas

Ban `DateTime` from the codebase

We should use DateTimeImmutable when possible, and consider BC/FC otherwise to use DateTimeInterface or not. This might mean in practice: use `DateTimeInterface` on arguments and `DateTimeImmutable` on return types. Ideally,...

[HttpKernel][HttpClient] `CachingHttpClient` should be configurable as a `private` cache

It would also make sense to have the persistence layer be based on our cache component I think. For the server side it doesn't make much sense, but the client...

[HttpKernel][HttpClient] `CachingHttpClient` should be configurable as a `private` cache

#36779 to the rescue. Help wanted to implement a client-side caching client.

Add constants for RFC 8631 to WebLink component

Good idea. Up to end a PR to add them?

[FrameworkBundle][Notifier] Allow to configure or disable the message bus to use

The failures are related I believe.

[FrameworkBundle][Notifier] Allow to configure or disable the message bus to use

Friendly ping @jschaedl

[Serializer] Add `SerializedPath` annotation to flatten nested attributes

@boenner I just force-pushed on your fork to fix all comments from @mtarld but one. Can you please have a look?

[Serializer] Add `SerializedPath` annotation to flatten nested attributes

Can you please update the PR's description if it's not in sync?

[Messenger] Kafka Transport Bridge

@KonstantinCodes still up to finish this? It looks like we're almost there. See remaining comments.

[Messenger] [Amqp-messenger] Support content encoding and compression

What about allowing compression/decompression with any transports? I guess we could add a middleware to do so? Right now, I see nothing really specific to AMQP. About the implementation, I'd...