Nicolas Grekas comments

Results 634 comments of


                                            Nicolas Grekas

Improve some PHPdocs based on existing Symfony stubs in PHPstan and Psalm

And thank you @mdeboer also!

[HttpClient] Upgrading from version 5.4.3 to version 5.4.5

@TomLorenzi if you still have the issue, I would be interested in reading the output of calling `$response->getInfo('debug')` before and after the issue has been introduced. Note that this call...

feature #47109 [Terminal] fewer syscalls when fetching $LINES/$COLUMNS

Thank you @wdoekes.

feature #47109 [Terminal] fewer syscalls when fetching $LINES/$COLUMNS

Merged in 02b8534e911323d20d90164271cb19754df5a759

[Messenger] Batch handlers v2

> The Result object in the example is used to acknowledge and set results to messages separately Note that the current design keeps LSP, aka batch handlers remain valid regular...

[EventDispatcher] Add support for a self-naming EventListener

Would removing `final` from `WrappedListener` unlock your use case?

[DomCrawler] `text()` method mangles UTF8 text

I'm sorry I'm unable to reproduce. We cannot blindly add the `u` modifier as that might 1. break parsing non-UTF8 html 2. trim more "spaces" than required.

[DomCrawler] `text()` method mangles UTF8 text

I'm on Linux. We could try replacing those `\s` by an explicit character class. But this is still strange and this creates a doubt for the other `\s` in the...

[DomCrawler] `text()` method mangles UTF8 text

Looks like pcre is using ctype to decide what is a space. Out of curiosity, what's the output of [this script](https://3v4l.org/3gTos) for you? Also, what's the output of `locale` on...

[DomCrawler] `text()` method mangles UTF8 text

Anyway, fixed in #47175