Nicolas Grekas

Results 634 comments of Nicolas Grekas

I'm sorry also to highlight this but the tone is so stressful here that it's hard to get into anything constructive. "burning", "broken", "forensic", "refuses explicitly to honour", "without any...

@pounard check https://github.com/symfony/symfony/blob/c3ad3eef655acaf092b114b1b22e2b2ec7b08624/src/Symfony/Component/ErrorHandler/ErrorHandler.php#L306 Please note also that: 1. `E_RECOVERABLE_ERROR` and `E_USER_ERROR` always stop execution and 2. `E_USER_DEPRECATED` are always silenced. This means 1. we must replace a silenced execution stop...

Most if not all deprecation are triggered with `@trigger_error()`. That is: `error_level()` returns `0`. The reporting level you can set before is just overridden during the call.

> we need a way to silent those as well. actually that's what the line you look at does: it removes any difference between calls with and without the `@`...

5.4 accepts only bug fixes now. Only 6.2 gets improvements.

> 1) Symfony\Component\HttpFoundation\Tests\Session\Storage\Handler\PredisClusterSessionHandlerTest::testUseSessionGcMaxLifetimeAsTimeToLive > Failed asserting that -2 is equal to 0 or is greater than 0. > C:\projects\symfony\src\Symfony\Component\HttpFoundation\Tests\Session\Storage\Handler\AbstractRedisSessionHandlerTestCase.php:103 > 2) Symfony\Component\HttpFoundation\Tests\Session\Storage\Handler\PredisClusterSessionHandlerTest::testDestroySession > Failed asserting that false is true. >...

> 1) Symfony\Component\Messenger\Bridge\Redis\Tests\Transport\RedisExtIntegrationTest::testGetNonBlocking Symfony\Component\Messenger\Exception\TransportException: NOGROUP No such key 'messenger-getnonblocking' or consumer group 'symfony' in XREADGROUP with GROUP option https://ci.appveyor.com/project/fabpot/symfony/builds/45276038#L2209

I've cherry-picked the changes on JsonEncoder in c693778940f379edf42272018cf8984e217befeb, on top of #45554, branch 5.4 I've updated the patch attached to this PR to keep only the part related to YamlEncoder....

`NoPrivateNetworkHttpClient` is opt-in, so that you should use it only on when running on a node where you need it. The `$subnet` constructor argument could also be useful to whitelist...

It makes sense yes. I think we don't need to have cooperation from decorated clients: the logic to retrieve the proxy is known (it's either in the options or in...