Nicolas Grekas

We can add an allow-list yes. It'd be up to users to properly configure this, but that's OK to me. As you wrote, auto-detection can be too hard.

I'm a bit late here but this means we are going to always send the Vary: Accept-Language header, isn't it? I'm not sure this is legit.

Oh, thanks. Two other issues: why on 6.2 and not on 6.1? And more importantly: the vary header should also be sent when $preferredLanguage is falsy. The code should look...

Now that #47695 is merged, shall we close here? :)

> personally don't care about this PSR since I'm using Symfony contracts I'd be fine extending the range of allowed characters when the Symfony contracts are used. Up for a...

We did not break anything, the colon we use is not on a PSR-6 boundary so the spec doesn't apply there. It's actually a good thing since it means public...

What about my proposal above? We can change our contracts.

I like `$pool->nest()`. Note that ProxyAdapter can be used for this use case: `$subPool = new ProxyAdapter($parentPool, 'sub-namespace');` But having a dedicated method + interface could be nice.

Tests fail, we need to override some methods from the base class.

Should we do this only when the contracts are used? Aka when using the PSR-6 interface, still throw?