Nicolas Grekas

Making this optional would work for me. Inorder to not break BC, the argument should be added using `@param` only and be accessed using func_get_arg

Here is the diff for the commentForm deprecation: ```diff --- a/templates/blog/post_show.html.twig +++ b/templates/blog/post_show.html.twig @@ -22,7 +22,7 @@ See https://symfony.com/doc/current/security/remember_me.html#forcing-the-user-to-re-authenticate-before-accessing-certain-resources #} {% if is_granted('IS_AUTHENTICATED_FULLY') %} - {{ render(controller('App\\Controller\\BlogController::commentForm', {'id': post.id})) }}...

Note that this would work also (and that'd skip the entity resolver entirely): ```diff --- a/templates/blog/post_show.html.twig +++ b/templates/blog/post_show.html.twig @@ -22,7 +22,7 @@ See https://symfony.com/doc/current/security/remember_me.html#forcing-the-user-to-re-authenticate-before-accessing-certain-resources #} {% if is_granted('IS_AUTHENTICATED_FULLY') %} -...

Can you please rebase so that we can trigger the CI again also?

Let me close, the presented arguments didn't convince me and nobody else chimed in to support this.

Up for a PR anyone? Keeping the issue open won't solve it by magic...

Thank you @lyrixx.

Thank you @santysisi.

You need to install it in your own deps yes, because you're using an optional feature of symfony/http-client.

php-http/message-factory is required when using HttplugClient from symfony/http-client before version 6.3. Since v6.3, you can use HttplugClient without installing php-http/message-factory.