Nicolas Grekas comments

Results 634 comments of


                                            Nicolas Grekas

[Cache] Add support for a tag lifetime in the RedisTagAwareAdapter

A new PR would be fine, to keep this one for history.

[Cache] Add support for a tag lifetime in the RedisTagAwareAdapter

Looking forward to your PR on the topic. Closing meanwhile, thanks for raising this point.

[BrowserKit] When uploading files, body is a Generator and no string

I reproduce the error and the issue doesn't seem to be in Symfony: - curl does *not* send any Content-Length header. This can be confirmed by dumping the response for...

[TwigBridge] Allow to set parent checkbox div class via {'row_class': 'foo'}

Since that's a new feature, this should target 6.2.

[TwigBridge] Allow to set parent checkbox div class via {'row_class': 'foo'}

@badmansan does @ker0x's comment make sense to you?

[Serializer] SerializedName based on groups

See https://github.com/symfony/symfony/pull/46432 ;)

[Ldap] Do not run ldap_set_option on failed connection

Thank you @tatankat.

[Dotenv] Start using virtual filesystem in tests

Works for me, I just wouldn't do the change preemptively. Instead, we should wait for the need on a case by case basis. I suppose this means we should merge...

CSP is not removed for exception pages in 6.1.4

Should be fixed by #47857

[Console][ErrorHandler] Add option to disable deprecations in dev console in 4.4

This line is correct: deprecations are always silenced already, see all the calls, they are like `@error_reporting()`, on purpose. You should be able to route the deprecation channel to wherever...