Nico Weber
Nico Weber
That'd be great!
Thanks! Have you considered making __tree_iterate_from_root check the root pointer? That allows removing a few other checks and looks like it might be less code (and you don't need the...
I hit "merge" on this, given it's been approved and fixes a regression. Thanks for the fix :)
Is this ready to merge? HEAD's been broken for quite a while now.
Looks nice! It's a bit surprising to me that it spawns a subprocess to take the screenshot -- couldn't it just call some code for that instead? (Maybe that code...
Another idea (which I'm also not voting for but just offering) is to keep the metadata for each test in that test, in a magic comment near the top of...
I went ahead and merged this. I think it's better than what we had before. We default to merging incremental improvements and iterating in-tree for code changes, so doing the...
(ps: Meh on the "10/10" comment.)
No big deal, all good :)