Nico Weber
Nico Weber
Normally we add APIs in the same PR that adds uses of the APIs. Do you have follow-on commits using this?
Yes, please add the `cp -i` changes to this PR too once they're ready.
> Modify the set_vp8x function to track the maximum width and height across all frames. That isn't necessarily enough. Some webp files have a canvas that's larger than all frames....
Re `{}`: In function decls with empty bodies, clang-format currently produces `{ }` with a space – unless there's an incorrect and needless `;` after the brace. Then it used...
Maybe it'd be nice to omit LibWeb here. That's mostly cherry-picks at the moment, and this here will make those even harder.
(#25458 renamed `BidirectionalClass` in LibUnicode to `BidiClass`, so that's what LibGfx should use now.)
Does adding a ``` # include ``` after the `` include help too?
Oh, Ubuntu-18.04 is ancient 😅 Up to you how far back you want to go with jakt support, I suppose :)
Understood. If it's just those 5 lines, that seems alright. If it's considerably more messy, maybe it isn't.
OutOfProcessWebView already depends on LibGUI, so short term putting it there looks like the clear path forward.