Nico Weber

Results 269 comments of Nico Weber

You need to run clang-format, see CI results.

In Terminal.app's built-in "Silver Aerogel", the text is visible too: (In most themes, it isn't.) So I suppose this isn't a reliable way to draw invisible text. (In Serenity's Terminal,...

Nice! Sorry for the clueless question: Is that a common big integer size for crypto use cases? If not, how does it compare at typical sizes?

Somewhat tangential, but given it's been discussed a bit, maybe it'd be useful to have a doc in-tree that describes the desired end state in windows.

I think it's great, I'm super excited about it, and I want to make some time to take a real look. I have some notes on this feature somewhere I'd...

``` Build/lagom/bin/image --to-bilevel=clustered4x4 -o out.webp orig.jpg Build/lagom/bin/image --to-bilevel=clustered8x8 -o out-clu.webp orig.jpg Build/lagom/bin/image --to-bilevel=bayer4x4 -o out-b4.webp orig.jpg Build/lagom/bin/image --to-bilevel -o out-fs.webp orig.jpg Build/lagom/bin/animation -o out-anim.webp --frame-duration-ms=500 orig.jpg out-fs.webp orig.jpg out-b4.webp orig.jpg...

I put the `animation` bits in #26432 since they're more straightforward :)

It decodes fine if I uncomment the check: ```diff diff --git a/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.cpp b/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.cpp index 4ec5f920478..4f82b6e3883 100644 --- a/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.cpp +++ b/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.cpp @@ -1299,8 +1299,8 @@ static ErrorOr parse_codestream_tile_headers(JPEG2000LoadingContext& conte TRY(parse_codestream_tile_header(context)); }...

Hm, looks like they're at the very end of the file. If I just remove the last three bytes of the file, it decodes fine. How did you extract the...